Fix long text making strange scroll behaviour, fix zIndex#133
Merged
ChinemeremChigbo merged 3 commits intomainfrom Apr 19, 2025
Merged
Fix long text making strange scroll behaviour, fix zIndex#133ChinemeremChigbo merged 3 commits intomainfrom
ChinemeremChigbo merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aa9c15f to
f2847f5
Compare
ChinemeremChigbo
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion Ticket
Ticket Name
Summary & Review Focus
I am a huge fan of Popovers and zIndex! (jkjk they are pretty annoying)
Fixes scroll issue with long email tags
Fixes role cell z index issues where they go above sticky row but not the "User Management" row
The issue with the long subject names making weird scroll behaviour is because of Popovers, especially popovers longer than the scroll view they are in
Fixed by removing them from the Portal (I am no longer a fan of portals since they often cause the thing where the whole page scrolls)
Also fixed by making the max width of the popover 80vw, since even taking it out of the portal made that weird thing happen where the line at the bottom of the header randomly stops and there's just blank space to the right
Since the portal is gone, the popover was above the sticky header but not the "User Management" header -> fixed by giving higher zIndex to sticky header and even higher to the filter popup lol, a little sketch but at this point i wasn't sure what else to do
Testing Instructions
Checklist